Merged
Conversation
janos
reviewed
Feb 27, 2025
gacevicljubisa
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A SOC can arrive at a node via push sync or pull sync.
With pull sync, you might not get all chunk versions because the newer version would have overridden the older one on the upstream node by the time you sync.
This issue doesn't exist when the listener node receives the chunk via pushsync as it will receive the chunk immediately after it is pushed. Effectively receiving all versions.
This PR ensures that the listener gets the chunk via push sync and such, we can verify consistently that it receives all versions.